Justinnn07/infinite scroll

[Justinnn07]

🚨 Please review the guidelines for contributing to this repository.

Please check if the PR fulfills these requirements

• [x] Make sure you are requesting to NEW-UI. Don't request other protected Branches like staging/master
• [x] Make sure no conflicts are present in the code, if so please resolve it(Tip: Always fetch upstream)
• [x] Your Commit messages should make sense.
• [x] Don't push your package.lock.json as this project uses yarn.lock already.
• [x] Check your code additions will fail neither code linting checks nor unit test.

Describe your changes

• What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Bought Infinite scrolling

• What is the current behavior? (You can also link to an open issue here)

• resolves #158

• Other Information:

• NULL

❤️ Thank you!

[vercel[bot]]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/stephin007/cowin-vaccine-availablity-checker/GkC1WxqgbRsCph2x4wq2rXsczxNS
✅ Preview: https://cowin-vaccine-availablity-checker-git-justinn-9bd698-stephin007.vercel.app

[stephin007]

@Justinnn07 i checked the UI, as soon as i reach the end of the vaccine array , the circular progress loader still shows and its flickers the whole UI.

[Justinnn07]

hey @stephin007 , I fixed those loading bugs, hopefully this works fine now!

I have a small suggestion, Can we make a button on scroll which will redirect us to the upper part of the home component .. Do let me know your reviews ..

Thanks ..

[stephin007]

hey @stephin007 , I fixed those loading bugs, hopefully this works fine now!

I have a small suggestion, Can we make a button on scroll which will redirect us to the upper part of the home component .. Do let me know your reviews ..

Thanks ..

@Justinnn07 Alright will check it tonight, And yes thats a good idea, we have floating buttons in material ui which we can use which will show an icon to go up to the top when we scroll down!

This is what you meant? right @Justinnn07

[Justinnn07]

hey @stephin007 , I fixed those loading bugs, hopefully this works fine now! I have a small suggestion, Can we make a button on scroll which will redirect us to the upper part of the home component .. Do let me know your reviews .. Thanks ..

@Justinnn07 Alright will check it tonight, And yes thats a good idea, we have floating buttons in material ui which we can use which will show an icon to go up to the top when we scroll down!

This is what you meant? right @Justinnn07

yes yes!

[stephin007]

@Justinnn07 your changes are not working on normal scroll in laptop which was not the case earlier.

But if i switch to mobile view, the infinite load is working but its not in the laptop view

[Justinnn07]

@Justinnn07 your changes are not working on normal scroll in laptop which was not the case earlier.

But if i switch to mobile view, the infinite load is working but its not in the laptop view

its working I guess 🤔🤔

[Justinnn07]

@stephin007 This works fine to me .. https://www.loom.com/share/7047f9babb6942509769a354d8ad4b64

Thanks

[stephin007]

@stephin007 This works fine to me .. https://www.loom.com/share/7047f9babb6942509769a354d8ad4b64

Thanks

Still its not working for me :(

[stephin007]

@Justinnn07 will merge this PR as soon as responsive UI PR is merged , its because of that only i am not able to seethe load more loader

[Justinnn07]

, its because of that only i am not able to seethe load more loader

sure sure