search

stephin007 / myportfolio

https://stephinreji.me
GNU General Public License v3.0
1 stars 2 forks source link

Need a dark theme switcher #20

Closed stephin007 closed 3 years ago

stephin007 commented 3 years ago

Well the title says it all. A switch which switches the light mode to a cool night mode.

chinmaym07 commented 3 years ago

Hey @stephin007 can I try this .. ?

stephin007 commented 3 years ago

Hey @chinmaym07 , thankyou for showing interest, please go ahead. But before starting please go through this link , it has the instructions on how to raise PR on open source projects. https://www.digitalocean.com/community/tutorials/how-to-create-a-pull-request-on-github

If you already know it, then never mind my statement 😄

stephin007 commented 3 years ago

@chinmaym07 any progress with this?

chinmaym07 commented 3 years ago

Hey @stephin007 I am working on it and will try to submit pr asap. :+1:

stephin007 commented 3 years ago

@chinmaym07 any progress yet?

chinmaym07 commented 3 years ago

Yes . I have done some part of that. I will surely try to submit the PR by today. :+1:

stephin007 commented 3 years ago

Sure, @chinmaym07

chinmaym07 commented 3 years ago

Hey @stephin007 I have tried this. Please check Shall I open a pr for the same.?

Screen Shot 2020-11-24 at 21 37 00 Screen Shot 2020-11-24 at 21 37 05

stephin007 commented 3 years ago

@chinmaym07 yes please do!

stephin007 commented 3 years ago

And @chinmaym07 please right align the switch to the left of the hamburger icon

chinmaym07 commented 3 years ago

I have opened a pr #21.

stephin007 commented 3 years ago

Thanks for working on this project @chinmaym07 your PR is merged now! Please do leave a star to this repo! you can check out my other projects if you get time and leave a star there also