fix for locators service not defined

stephpy / timeline-bundle

Symfony2 bundle to make timeline

193 stars 57 forks source link

fix for locators service not defined #127

Closed Miliooo closed 10 years ago

Miliooo commented 10 years ago

This is a fix for issue https://github.com/stephpy/TimelineBundle/issues/125

[x] Supports the config for loading locators
[x] Supports tags for loading locators
[x] Tested it locally

I created a new class since I wanted to try and write tests for it. (Supporting another unrelated methodcall to a different service would have made that even more difficult.) The tests are ugly but it's something ;)

stephpy commented 10 years ago

Yep, you are right for tags ! thanks for theses improvements. :)

Miliooo commented 10 years ago

Did some updates to make it BC with tags updated my main message

stephpy commented 10 years ago

Thanks, you're awesome :+1: :)