search

stephpy / timeline-bundle

Symfony2 bundle to make timeline
192 stars 57 forks source link

more improvements #142

Closed cordoval closed 10 years ago

cordoval commented 10 years ago

@stephpy :ship: :it:

Miliooo commented 10 years ago

I'm not sure why you want to remove the phpdoc for classes. Even symfony has those.

cordoval commented 10 years ago

it is a long but very consistent story, i will blog about it at craftitonline.com when i get a chance soon probably. The reasons have to do with maintainability of code, less scrolling, less redundancy, no need for those ugly useless blocks when the information is already evident in github/git/composer.json, and several others i will expand on later on. The new state of the code reads beautifully and fast.

Miliooo commented 10 years ago

Ok I just saw https://github.com/stephpy/timeline/issues/35. I agree with most of your things. The uses tag is not used consistently anyways. The author tag is not needed either.

When the phpdoc has no information you could remove it I guess. Better would be if the phpdoc does contain some information. That's just my two cents

cordoval commented 10 years ago

@stephpy i see it green, that means is good to go for now, i will launch a new PR

stephpy commented 10 years ago

I wait for your new PR to make a 2.0.1 version. :)

Thanks.

cordoval commented 10 years ago

no please do not wait, bump it up, we will never run out of numbers, they are infinite! @stephpy i will blog post about this too, it just does not make sense to wait.