Fixed fatal error in dependency injection config

stephpy / timeline-bundle

Symfony2 bundle to make timeline

192 stars 57 forks source link

Fixed fatal error in dependency injection config #202

Closed pppdns closed 7 years ago

pppdns commented 7 years ago

$definition->addMethodCall(...) on L111 results in Fatal error: Call to undefined method Symfony\Component\DependencyInjection\Reference::addMethodCall(). This is because $definition is Reference type, though it should be Definition type which has the addMethodCall method

see https://github.com/stephpy/timeline-bundle/commit/ff9c3e740887e39d21b7e7521b589728d590a98c#commitcomment-21808406 for more details

Strategy47 commented 7 years ago

I have the same problem after a composer update this PR is correct! Please merge.

stephpy commented 7 years ago

Thanks, fixed on https://github.com/stephpy/timeline-bundle/releases/tag/v2.4.1

Strategy47 commented 7 years ago

Thanks