search

stephpy / timeline

Standalone library to make a timeline.
MIT License
89 stars 20 forks source link

$persistedDatas not cleared in Redis TimelineManager #12

Closed pulse00 closed 11 years ago

pulse00 commented 11 years ago

We're running a rabbitMQ consumer which is responsible for creating timeline entries through spreads in our application.

As this consumer is a long running PHP process, we've notice a potential bug in the implementation of the flush() method. The persistedDatas array is never being cleared after a flush operation, therefore if you run the flush operation multiple times inside a rabbitMQ consumer, you'll end up with duplicate entries - at least that's what happening in our application.

stephpy commented 11 years ago

Sure, nice catch, it has to be cleared after flush operation !