search

stephskardal / rails_admin_import

Rails Admin Import functionality
http://www.endpoint.com/
MIT License
160 stars 122 forks source link

file_importer.rb crash when logger is activate #49

Closed yovasx2 closed 8 years ago

yovasx2 commented 8 years ago

When logger is active, the method copy_uploaded_file_to_log_dir has a problem when dir import does not exist, so I use the FileUtils.makedir_p to create it and prevent FileUtils.cp not to crash

monkbroc commented 8 years ago

Thanks for the bug report. I'll take a look at your fix.

yovasx2 commented 8 years ago

ok bro

monkbroc commented 8 years ago

Thanks for the reminder to look at this. I added a test for turning on the logging so this doesn't break again in the future. I'm releasing 1.3.1 with this bugfix. Thanks!

yovasx2 commented 8 years ago

Your welcome bro have a nice day On Feb 11, 2016 9:36 PM, "Julien Vanier" notifications@github.com wrote:

Thanks for the reminder to look at this. I added a test for turning on the logging so this doesn't break again in the future. I'm releasing 1.3.1 with this bugfix. Thanks!

— Reply to this email directly or view it on GitHub https://github.com/stephskardal/rails_admin_import/pull/49#issuecomment-183168510 .