Fix missing TARGET_ENCODINGS constant in latest rails_admin

stephskardal / rails_admin_import

Rails Admin Import functionality

http://www.endpoint.com/

MIT License

160 stars 122 forks source link

Fix missing TARGET_ENCODINGS constant in latest rails_admin #68

Closed patricklewis closed 8 years ago

patricklewis commented 8 years ago

I'm working on a Rails 5 beta app and had to install rails_admin directly from the GitHub repository to get it working on Rails 5.

Recent commits to rails_admin have removed the RailsAdmin::CSVConverter::TARGET_ENCODINGS constant which was used by rails_admin_import to populate the Encoding dropdown on the import form:

As a workaround, I've copied the TARGET_ENCODINGS constant into a new RailsAdminImport::Encodings module to remove the dependency on rails_admin.

monkbroc commented 8 years ago

Thanks for your work in isolating this issue.

I think it will be best to go with the solution in #71. Could you check if the latest master branch works for you?

patricklewis commented 8 years ago

Looks like the fix in #71 works well and is a better long-term solution than my stopgap in this PR. 👍