search

stephskardal / rails_admin_import

Rails Admin Import functionality
http://www.endpoint.com/
MIT License
160 stars 122 forks source link

Updated code that lists target encodings #71

Closed baldursson closed 8 years ago

baldursson commented 8 years ago

The previous code that was supposed to fetch a list of encodings was using a constant from Rails Admin that is no longer available. This caused an error when using an up-to-date version of Rails Admin. This fix fetches encodings the same way Rails Admin does nowadays.

monkbroc commented 8 years ago

Thanks for finding a good solution to this problem.

Could you confirm that this works both with Rails 4 and Rails 5?

monkbroc commented 8 years ago

I published a new version as 2.0.0 since this changes an external dependency. In case people want the old import they can stay with 1.x