stephskardal / rails_admin_import

Rails Admin Import functionality
http://www.endpoint.com/
MIT License
160 stars 122 forks source link

add french translation contribution #73

Closed rodinux closed 8 years ago

rodinux commented 8 years ago

A suggestion to help french users. I also explain how I fixed an issue with Datepicker on rails_admin. Regards

monkbroc commented 8 years ago

Merci.

Maybe you included the wrong link in the readme? It links to your fork, not to a file with French translations.

rodinux commented 8 years ago

I put this link because I have also to change date formats on rails_admin.fr.yml and fr.yml to resolve an issue with Datepicker (Datepicker don't show selected date properly). So I put these files needed to get the translation in french working.

monkbroc commented 8 years ago

Your fork currently only has one commit on top of master https://github.com/rodinux/rails_admin_import/commit/1d20f9d9f815194d2028c76872bf22e570d52b13 It only has the change to the readme. The rails_admin.fr.yml and fr.yml are missing.

rodinux commented 8 years ago

Hi, I put the file fr into the locales directory and it works, also on my project. regards

rodinux commented 8 years ago

I explain better why it's a good idea to change also the translation for rails_admin and add a suggestion to do it... No more regards

monkbroc commented 8 years ago

I'd like to keep the link to https://github.com/rodinux/rails_admin_import.fr-MX.yml only in the README and not have the rails_admin.fr.yml in the pull request. The link https://github.com/rodinux/rails_admin_import.fr-MX.yml has all that is needed if someone wants to add French translations to rails_admin_import.

I don't have the time or knowledge to maintain all the translations myself so I'd rather just have links to a place where the translation is maintained instead of pulling in the translation into the main repository.

rodinux commented 8 years ago

ok, I delete the file rails_admin_import.fr and change the notifications as you say.

monkbroc commented 8 years ago

C'est bon! Merci encore!