search

stephskardal / rails_admin_import

Rails Admin Import functionality
http://www.endpoint.com/
MIT License
160 stars 122 forks source link

Switch to using CharlockHolmes for character encoding detection #96

Closed codealchemy closed 5 years ago

codealchemy commented 5 years ago

rchardet uses LGPL, which doesn't align with the license for this gem (MIT - which is the same as rails and rails_admin) and can be fairly restrictive for uses in private projects.

This updates to use CharlockHolmes - the interface of which is effectively the same and is on an MIT license as well.

codealchemy commented 5 years ago

Another consideration worth noting is charlock_holmes requires ICU - unsure that would be a deal-breaker or if other alternatives would be preferable.