search

stephy / CalendarPicker

CalendarPicker Component for React Native
787 stars 369 forks source link

External images in source code #2

Closed edvinerikson closed 9 years ago

edvinerikson commented 9 years ago

Is there any specific reason you are having the images separated from the repo? The current solution isn't the best because it's creating an huge dependency to the website that hosts those images.

I would suggest that we change 

source={{ uri: 'http://stephanimoroni.com/kalendar/images/arrow-left@3x.png'}}/>

(source) to 

source={{ uri: 'images/arrow-left@3x.png'}}/>

and the same with the right arrow. (source)

stephy commented 9 years ago

@edvinerikson, @brentvatne Thank you for pointing that out. I used the url because I couldn't make the images load locally. I read up online and I finally figured it out.

Here's the commit with the change: https://github.com/stephy/CalendarPicker/commit/e573b145ce37ba02d8d948453363df542308f0ab

brentvatne commented 9 years ago

:+1: :smile:

edvinerikson commented 9 years ago

Awesome! :smile: I will close this now.