stephy / CalendarPicker

CalendarPicker Component for React Native
802 stars 371 forks source link

vertical line divider after selecting a date range #251

Open grantalba opened 3 years ago

grantalba commented 3 years ago

https://stackoverflow.com/questions/64747135/how-to-remove-the-line-divider-in-the-react-native-calendar-picker-after-selec

See picture in stackoverflow.

peacechen commented 3 years ago

Haven't seen that before. Are you seeing that on a physical device or the emulator? Which device and/or emulator?

jingfreeks commented 3 years ago

ios emulator and physical device

peacechen commented 3 years ago

I apologize for not having time to debug this. Please submit a PR if you find the bug.

PrabhakarKotipalli commented 3 years ago

dayLabelsWrapper = {{borderWidth:0,borderColor:'white'}}

just add whatever ur background color is to the bordercolor

pallpointben commented 3 years ago

@PrabhakarKotipalli that is a different issue. Refer to the picture in the attached post.

I am also experiencing this issue. iPhone 11 emulator.

Simulator Screen Shot - iPhone 11 - 2021-04-28 at 22 03 37

metasection commented 3 years ago

I see something similar on the Expo Go app running on iOS. Same code works fine with react-native-web which is very cool.

Screen Shot 2021-05-20 at 4 28 37 PM

Here is some test code...

`

return (

);

`

rajeshkannanrajagopal commented 3 years ago

Same issue facing in all IOS device alone but in android it works well.

any idea about this?

image

rayjackson13 commented 3 years ago

This has been open for almost a year now. Is there still no resolution to this?

I'm experiencing the same issue: image

I'm using react-native-calendar-picker:^7.12. This happens when selecting a range of dates with the following code:

<CalendarPicker allowRangeSelection />

This is all the code you need to be able to repro this issue, then you just need to select a range between two dates.

Upd. I've found that this happens because there's a decimal number specified as the width (for me it was 55.2 on iPhone 11 Sim)

peacechen commented 3 years ago

Unfortunately I didn't have time to debug this. It seems to be device/OS specific so I had a difficult time recreating it. Happy to see that @rayjackson13 found the cause. Would you submit a PR to restrict widths to integer values?

talon-himself commented 2 years ago

@peacechen it looks like a PR has been open for this since October 2021. Any idea when this fix will go in?