search

stephy / CalendarPicker

CalendarPicker Component for React Native
787 stars 369 forks source link

feat: Added prop for fontScaling for allowing font scale (#358 & #349) #362

Closed SanyaPillai closed 5 months ago

SanyaPillai commented 5 months ago

Added prop for font scaling for enabling and disabling font scaling in calendar picker.

tranjog commented 5 months ago

Thanks @SanyaPillai! This looks like a good addition to the library. Could you please update the version number in package.json to 8.0.1?

@peacechen Looks good to me 👍

peacechen commented 5 months ago

Thanks @SanyaPillai Please update the Readme with the new prop

SanyaPillai commented 5 months ago

@tranjog and @peacechen Updated the PR as per the comments added

peacechen commented 5 months ago

Thanks @SanyaPillai Upon review, I spotted performance and readability change that should be made.

SanyaPillai commented 5 months ago

@peacechen , I have made the changes to PR as per the comment for imporving readability and performance

Screenshot 2024-01-29 at 10 58 40 AM
peacechen commented 5 months ago

Thanks @SanyaPillai @tranjog Would you like to publish this version?

tranjog commented 5 months ago

Thanks both, 8.0.1 has been published: https://www.npmjs.com/package/react-native-calendar-picker

@peacechen Please close these two: https://github.com/stephy/CalendarPicker/issues/349 https://github.com/stephy/CalendarPicker/issues/358