search

stephy / CalendarPicker

CalendarPicker Component for React Native
788 stars 370 forks source link

@providesModule naming collision #59

Closed antsmo closed 6 years ago

antsmo commented 7 years ago

I just upgraded to the latest RN and I'm getting a load of @providesModule naming collision errors coming from CalendarPicker - too many to paste them all but for example..

This warning is caused by a @providesModule declaration with the same name across two different files.
Failed to build DependencyGraph: @providesModule naming collision:
  Duplicate module name: react-native-vector-icons
  Paths: /Users/simon/dev/MyApp/node_modules/react-native/local-cli/core/__fixtures__/files/package.json collides with /Users/simon/dev/MyApp/node_modules/react-native-calendar-picker/node_modules/react-native/local-cli/core/__fixtures__/files/package.json

I can't really figure out if this is a RN issue or something that can be addressed in this component. The latter seems more likely as it's the only package I've added since and comes up in all of the errors.

Thanks

RN v0.43.3 CalendarPicker v5.7.0

antsmo commented 7 years ago

So I've fixed this by pointing to the github repo rather than NPM. I'm guessing MASTER contains some fixes not yet published to NPM?

ShadyXV commented 7 years ago

I had the same problem after installing this package. RN v0.43.3 CalendarPicker v5.7.0 Re-installing the package from did fix this issue.Thanks @MyGuySi

LEEY19 commented 7 years ago

@MyGuySi hi, how did you 'point' to github repo?

antsmo commented 7 years ago

@LEEY19 here you go - http://stackoverflow.com/questions/17509669/how-to-install-an-npm-package-from-github-directly

blaine0611 commented 7 years ago

Thanks @MyGuySi , it helps me a lot

chibeepatag commented 7 years ago

After pointing to the github repo i got TransformError Couldn't find preset "babel-preset-expo" Any hints?

jjwon0 commented 7 years ago

This appears to have been fixed in c9bc2661775c6a39194275cdcec02d52acc1e352, which is why pointing at the GitHub repo should work.

@chibeepatag did it work after you removed and reinstalled the package?

chibeepatag commented 7 years ago

@jjwon0 Its working now. I had to npm install babel-preset-expo --save.

peacechen commented 7 years ago

Dup of #55 and resolved in PR #56.

babel-preset-expo was reported in #63 and resolved in PR #65. Since it's a peer dependency, installing it to the parent project is the correct action.