search

stephy / CalendarPicker

CalendarPicker Component for React Native
792 stars 369 forks source link

react-native in dependencies breaks build #85

Closed peacechen closed 6 years ago

peacechen commented 6 years ago

Commit 6c253d9a80a91635f38a8ccc76eb267e599fe1c0 re-introduced react-native to dependencies again. This results in the error Update UnableToResolve 'ActivityIndicator' due to a nested copy of react-native inside CalendarPicker.

@stephy : please prioritize removing it and publishing an update to npm as it's breaking any react-native project using this library.

peacechen commented 6 years ago

Fixed it in my fork. Since there's an outstanding PR, that commit got lumped in with #84

peacechen commented 6 years ago

ping @stephy

wmonecke commented 6 years ago

@peacechen Could you please let me know how I can fix this error. I literally am spending hours to fix this.

peacechen commented 6 years ago

In your package.json, point to my fork until stephy merges and publishes an update.

    "react-native-calendar-picker": "https://github.com/peacechen/CalendarPicker",

Depending on the state of your project, you may need to delete node_modules and reinstall.

nishiltamboli commented 6 years ago

Thanks @peacechen your fork does look to have solved the issue.

stephy commented 6 years ago

@peacechen Hey Thanks for creating a fork and helping everyone out. I have been super busy! Where is the PR you created to solve this issue? I will merge it.

peacechen commented 6 years ago

PR #84 Includes the react-native dependency fix. It includes a number of other fixes & features. They are relatively minor and have been working well in our app for a while.