Closed ElvisChiang closed 6 years ago
This library shouldn't require any version-specific features in Node 7.x. Recommend changing the package.json to:
"engines" : {
"node" : ">=4.0.0"
},
I haven't tested Node 4.x, but seems like it would be better to support as many versions back as possible.
same issue for me.
This has been fixed in the main branch but hasn't been published to npm. You can point your package.json to this repo for the time being.
@peacechen thanks for reply but i removed it from package.json and when i want to rerun react-native-git-upgrade command i get this error:
fsevents@1.1.2: The platform "win32" is incompatible with this module. react-native-jalali-calendar-picker@0.2.6: The engine "node" is incompatible with this module. Expected version ">=7.6.0". Found incompatible module
@derakhshanfar After modifying your fork react-native-jalali-calendar-picker
, you should re-run npm install to sync node_modules.
@peacechen i re-run npm install but it does not work. i get same error
fsevents@1.1.2: The platform "win32" is incompatible with this module. react-native-jalali-calendar-picker@0.2.6: The engine "node" is incompatible with this module. Expected version ">=7.6.0". Found incompatible module
@peacechen is it possible to cut a release soon to fix the node >4 issue? Thanks, much appreciated.
The current release (5.11.0) fixed the node version requirement. Its package.json has
"engines": {
"node": ">=4.0.0"
},
Please make sure you're using the current release in your package.json.
"react-native-calendar-picker": "^5.11.0",
If that's specified, check that your package-lock.json points to the correct version too (or yarn if you use that).
@peacechen this is what npm sees for 5.11: https://unpkg.com/react-native-calendar-picker@5.11.0/package.json
Which seems in line with the fact that the nod 4.0 pr was merged on November 27th (https://github.com/stephy/CalendarPicker/pull/96)
and that the version bump was cut on November 16th
https://github.com/stephy/CalendarPicker/commit/92ae0b1989ec2bab6baa085b3db716700fca7342
@trekare Thanks for noticing the discrepancy. I got my wires crossed on the commits 😮
I've published 5.12.0 which also includes a number of styling prop additions as well as conversion to Moment JS. Users will need to add moment
to the project's dependencies (see #95).
72ecec0 actually removed node6 support