search

stepstone-tech / android-material-stepper

This library allows to use Material steppers inside Android applications.
Apache License 2.0
1.78k stars 261 forks source link

Prefix too common #238

Open Quentin1010 opened 6 years ago

Quentin1010 commented 6 years ago

Your resources' name may be a bit too simple and common. The prefix "ms_" is too short and can lead to conflicts.

Here is my issue on Stack : https://stackoverflow.com/questions/48344940/attribute-duplicated-in-libraries

briananderson1222 commented 6 years ago

https://github.com/ganfra/MaterialSpinner/pull/112 - this should fix this specific issue.. If only we could get it merged :)

Quentin1010 commented 6 years ago

Oh, I didn't notice your request, thanks! Now let's wait :)

briananderson1222 commented 6 years ago

@ganfra does not seem to be very responsive on github these days. This Material Stepper repo seems to be a little more active. Any chance at either changing the prefix or fixing the reference (I know the reference change is brittle but would allow you to keep your prefix).. These two repositories seem to be widely used and are currently incompatible with each other @zawadz88

zawadz88 commented 6 years ago

Hi all, Changing a prefix seems a bit drastic if I'm to be honest. I think it's only a matter of time until a new Material-Something library comes along using the new prefix as well. If I understand this correct the only issue is with ms_errorColor attribute? If so maybe rename it to ms_tabErrorColor as it's only used for the tabs anyway? This would still introduce a breaking API change, but I think it would be a lesser evil.