stereobooster / jekyll-press

🚨 [deprecated] Minifier plugin for jekyll. Minifies all html, js, css files. Simple just drop it in solution. No Java required
MIT License
148 stars 13 forks source link

"Building site..." forever #3

Closed zenorocha closed 12 years ago

zenorocha commented 12 years ago

I followed your steps and then hit jekyll to generate my website, but it takes forever and don't generate. Here's the source code.

Do you have any ideas @stereobooster?

stereobooster commented 12 years ago

Problem is that documentation not very clear (for not rubyist). You instal jekyll globally (gem install jekyll), but all other gems you install in some kind of sandbox (bundle).

You can try this:

  1. add gem "jekyll" to Gemfile
  2. run bundle
  3. use bundle exec jekyll instead of jekyll command

Meanwhile I will think if there easier way.

zenorocha commented 12 years ago

Still the same problem =/

stereobooster commented 12 years ago

It's actually working (https://gist.github.com/3760064). Taking too much time. Need to benchmark html_press.

zenorocha commented 12 years ago

Yeah, now it worked here, but it took almost 20min

stereobooster commented 12 years ago

I found the problem: slow regexps

This is very slow (even if there are no script tags)

/\s*(<script\b[^>]*?>[\s\S]*?<\/script>)\s*/i

this is much faster

/<script\b[^>]*?>[\s\S]*?<\/script>/i

I need some more time to decide what is the best fix

zenorocha commented 12 years ago

Nice, good to know.

stereobooster commented 12 years ago

Updated html_press. Try bundle update and bundle exec jekyll

stereobooster commented 12 years ago

Fix readme and add warning if gems not installed