stereobooster / jekyll-press

🚨 [deprecated] Minifier plugin for jekyll. Minifies all html, js, css files. Simple just drop it in solution. No Java required
MIT License
148 stars 13 forks source link

Does not support CSS3 syntax #9

Closed wei2912 closed 11 years ago

wei2912 commented 11 years ago

The plugin is unable to parse some CSS3 syntax.

For example, look at https://github.com/linuxtuts/linuxtuts.github.com

parse error occurred while processing: /_site/css/colors/transparent.css
details: parse error on value "$" ($end)
copying initial file
parse error occurred while processing: /_site/css/depend/fixstyles.css
details: parse error on value ":not(" (error)
copying initial file
parse error occurred while processing: /_site/css/mqs/print.css
details: parse error on value "^=" (error)
copying initial file
Successfully generated site: linuxtuts.github.com -> linuxtuts.github.com/_site
stereobooster commented 11 years ago

Is there a git repo (or zip) where this bug can be reproduced?

wei2912 commented 11 years ago

Yes, github.com/linuxtuts/linuxtuts.github.com

stereobooster commented 11 years ago

I'm getting following:

parse error occurred while processing: /_site/css/colors/transparent.css
details: parse error on value "$" ($end)
copying initial file
parse error occurred while processing: /_site/css/depend/fixstyles.css
details: parse error on value ":not(" (error)
copying initial file
parse error occurred while processing: /_site/css/mqs/print.css
details: parse error on value "^=" (error)
copying initial file
Successfully generated site: linuxtuts.github.com -> linuxtuts.github.com/_site

So jekyll-press processing all files, but css_press can't minify them beacuse there is parse errors. Parse errors are caused beacause csspool doesn't support all css3 syntax. See issue tracker

I'm thinking about make it possible to use other css minifiers.

wei2912 commented 11 years ago

Oh, so that's why... and yes, my site uses CSS3 syntax.

stereobooster commented 11 years ago

Duplicate of #8

stereobooster commented 11 years ago

I added ability to swap css minifier (see my new gem multi_css). To use other css minifier simply add it to Gemfile. Try for example gem "cssminify"