minimalcss to use its own puppeteer.launch

stereobooster / react-snap

👻 Zero-configuration framework-agnostic static prerendering for SPAs

MIT License

5.04k stars 391 forks source link

minimalcss to use its own puppeteer.launch #357

Open ilanbm opened 5 years ago

ilanbm commented 5 years ago

Letting minimalcss use a different instance of puppeteer than react-snap.

referring to #314 , it says there "Do the same as minimalcss peterbe/minimalcss#223"

If I got it correct they removed service workers to solve puppeteer's "cannot read property 'ok' of null" issue. so if we want react-snap to use service workers, then minimalcss should use it's own puppeteer instance that includes their solution that is probably not using service workers.

ilanbm commented 5 years ago

an-almost-static-stack tests succeed

brycedorn commented 4 years ago

hey, this resolved the issue for me. I didn't need the change in puppeteer_utils (only tested with one page) but since the other change is specific to inlineCss and that's currently broken could this be merged?