stereobooster / react-snap

👻 Zero-configuration framework-agnostic static prerendering for SPAs
MIT License
5.04k stars 391 forks source link

Fixes #212, check url port before crawling #373

Closed Stanko closed 5 years ago

Stanko commented 5 years ago

Description

Made sure that before adding url to the queue, link's port matches the application port.

I converted both ports to string, to be sure, as the one in options is a number, but the parsed one is a string.

Fixes #212

stereobooster commented 5 years ago

It would be nice to add test for this 👍

Stanko commented 5 years ago

Sure thing! I'll probably push it tomorrow.

Stanko commented 5 years ago

I added 404.html, wasn't sure if it was missing on purpose, but all tests are still passing.