stereolabs / zed-gstreamer

Package of GStreamer elements to interface with ZED Cameras
https://www.stereolabs.com/docs/gstreamer/
61 stars 23 forks source link

Camera Control #12

Closed tonyf closed 3 years ago

tonyf commented 3 years ago

Are ZED SDK v3 camera control features such as ROI, Exposure and Gain controls planned for the zedsrc plugin?

Myzhar commented 3 years ago

Hi @tonyf , camera control parameters will be added in a future release.

alexander-jiang commented 3 years ago

Hi @Myzhar , is there any update on adding the camera control features above (and other settings e.g. sharpness, brightness, white balance etc.) to the zedsrc plugin? If not, I can open a PR to implement them (is there a contributions guide for this repo?)

Myzhar commented 3 years ago

Hi @alexander-jiang the camera control feature will be added soon

Myzhar commented 3 years ago

@alexander-jiang if you want to test camera controls you can pull and check out the devel branch. After compilation and installation, you can see the list of the new parameters with the command $ gst-inspect-1.0 zedsrc

  brightness          : Image brightness
                        flags: readable, writable
                        Integer. Range: 0 - 8 Default: 4 
  contrast            : Image contrast
                        flags: readable, writable
                        Integer. Range: 0 - 8 Default: 4 
  hue                 : Image hue
                        flags: readable, writable
                        Integer. Range: 0 - 11 Default: 0 
  saturation          : Image saturation
                        flags: readable, writable
                        Integer. Range: 0 - 8 Default: 4 
  sharpness           : Image sharpness
                        flags: readable, writable
                        Integer. Range: 0 - 8 Default: 4 
  gamma               : Image gamma
                        flags: readable, writable
                        Integer. Range: 1 - 9 Default: 8 
  gain                : Camera gain
                        flags: readable, writable
                        Integer. Range: 0 - 100 Default: 60 
  exposure            : Camera exposure
                        flags: readable, writable
                        Integer. Range: 0 - 100 Default: 80 
  aec-agc             : Camera automatic gain and exposure
                        flags: readable, writable
                        Boolean. Default: true
  aec-agc-roi-x       : Auto gain/exposure ROI top left 'X' coordinate (-1 to not set ROI)
                        flags: readable, writable
                        Integer. Range: -1 - 2208 Default: -1 
  aec-agc-roi-y       : Auto gain/exposure ROI top left 'Y' coordinate (-1 to not set ROI)
                        flags: readable, writable
                        Integer. Range: -1 - 1242 Default: -1 
  aec-agc-roi-w       : Auto gain/exposure ROI width (-1 to not set ROI)
                        flags: readable, writable
                        Integer. Range: -1 - 2208 Default: -1 
  aec-agc-roi-h       : Auto gain/exposure ROI height (-1 to not set ROI)
                        flags: readable, writable
                        Integer. Range: -1 - 1242 Default: -1 
  aec-agc-roi-side    : Auto gain/exposure ROI side
                        flags: readable, writable
                        Enum "GstZedsrcSide" Default: 2, "Left and Right side"
                           (0): Left side only   - LEFT
                           (1): Right side only  - RIGHT
                           (2): Left and Right side - BOTH
  whitebalance-temperature: Image white balance temperature
                        flags: readable, writable
                        Integer. Range: 2800 - 6500 Default: 4600 
  whitebalance-auto   : Image automatic white balance
                        flags: readable, writable
                        Boolean. Default: true
  led-status          : Camera LED on/off
                        flags: readable, writable
                        Boolean. Default: true

Please send me your feedback in case you test it.

Myzhar commented 3 years ago

The Camera controls are now available in the master branch. @alexander-jiang please close this issue if everything works as expected

Tetsujinfr commented 3 years ago

hi, the params works fine on my side through the gstreamer command. I did test brightness and gain, not all the params though. @tonyf , @alexander-jiang , good to close this issue?

alexander-jiang commented 3 years ago

@Myzhar @Tetsujinfr The settings seem to be working (I just tested with camera flip but the source code looks correct), so let's close this issue for now, and if anything doesn't appear to be working, we can re-open later.