Closed ryanppeters closed 1 year ago
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment otherwise it will be automatically closed in 5 days
Pinging to prevent auto close
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment otherwise it will be automatically closed in 5 days
@Myzhar Pinging to prevent auto-close
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment otherwise it will be automatically closed in 5 days
Realized I made a mistake in my previous PR that the parameters for
setRegionOfInterest
were checked if they were invalid, and if so, then create the ROI. This PR fixes it so when all roi parameters (roi-x, roi-y, roi-w, roi-h
) are valid, the ROI is assigned. (Turns out, my use case at the time was an edge case so that's how I did not find this)Verified changes by the following test cases for
roi=1
andcamera-resolution=1
(1080p):roi-x=0
,roi-y=0
,roi-w=1920
,roi-h=1080
-> PASSroi-x=-1
,roi-y=0
,roi-w=1920
,roi-h=1080
-> FAILroi-x=0
,roi-y=-1
,roi-w=1920
,roi-h=1080
-> FAILroi-x=0
,roi-y=0
,roi-w=1921
,roi-h=1080
-> FAILroi-x=0
,roi-y=0
,roi-w=1920
,roi-h=1081
-> FAILroi-x=1080
,roi-y=0
,roi-w=1
,roi-h=1
-> FAILroi-x=0
,roi-y=1920
,roi-w=1
,roi-h=1
-> FAIL