stereolabs / zed-gstreamer

Package of GStreamer elements to interface with ZED Cameras
https://www.stereolabs.com/docs/gstreamer/
61 stars 23 forks source link

Bugfix for checking valid roi parameters #45

Closed ryanppeters closed 1 year ago

ryanppeters commented 1 year ago

Realized I made a mistake in my previous PR that the parameters for setRegionOfInterest were checked if they were invalid, and if so, then create the ROI. This PR fixes it so when all roi parameters (roi-x, roi-y, roi-w, roi-h) are valid, the ROI is assigned. (Turns out, my use case at the time was an edge case so that's how I did not find this)

Verified changes by the following test cases for roi=1 and camera-resolution=1 (1080p):

github-actions[bot] commented 1 year ago

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment otherwise it will be automatically closed in 5 days

ryanppeters commented 1 year ago

Pinging to prevent auto close

github-actions[bot] commented 1 year ago

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment otherwise it will be automatically closed in 5 days

ryanppeters commented 1 year ago

@Myzhar Pinging to prevent auto-close

github-actions[bot] commented 1 year ago

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment otherwise it will be automatically closed in 5 days