Add Opencv Calibration File parameter to zedsrc element

stereolabs / zed-gstreamer

Package of GStreamer elements to interface with ZED Cameras

https://www.stereolabs.com/docs/gstreamer/

61 stars 23 forks source link

Add Opencv Calibration File parameter to zedsrc element #52

Closed jdcast closed 3 months ago

jdcast commented 4 months ago

Allows the zedsrc gstreamer element to be called with a parameter for loading a opencv calibration file: optional-opencv-calibration-file.

Myzhar commented 4 months ago

Thank you for this feature. Please read my comments and apply the simple fixes, then I will merge it

jdcast commented 4 months ago

Thank you for this feature. Please read my comments and apply the simple fixes, then I will merge it

Hi @Myzhar, I don't see your comments. Where are they?

Myzhar commented 4 months ago

They are in the review of the Pull Request

jdcast commented 4 months ago

They are in the review of the Pull Request

@Myzhar sorry to have to follow up again, but I don't see any reviews on my end for this PR. I also don't see comments in the file changes tab either.

This is what I see:

Myzhar commented 4 months ago

@jdcast I'm sorry, I did not submit the review

jdcast commented 4 months ago

@Myzhar I've made the changes you requested.

jdcast commented 3 months ago

Hi @Myzhar just pinging you on this before it goes stale.

Myzhar commented 3 months ago

Merged