stereolabs / zed-ros-wrapper

ROS wrapper for the ZED SDK
https://www.stereolabs.com/docs/ros/
MIT License
447 stars 391 forks source link

mag, baro and temperature frames not included for model == 'zed2i' #821

Closed Srijal97 closed 2 years ago

Srijal97 commented 2 years ago

Preliminary Checks

Description

In the zed_macro.urdf.xacro file, _mag_link, _baro_link, _temp_right_link, and _temp_left_link are assigned only if the mdoel == 'zed2', but it should also be assigned for the ZED2i as well.

The ZED2i already reports these sensor data with the above frame IDs, but the frame IDs do not exist. This is a small fix, and I have done it on my end.

Steps to Reproduce

Start the zed_wrapper with camera model set to zed2i. Topics for /imu/mag and other sensors are published, but the frame IDs do not exist.

Expected Result

Frame IDs published via the URDF for the relevant sensors.

Actual Result

Relevant Frame IDs do not exist in the URDF.

ZED Camera model

ZED2i

Environment

Ubuntu 18, ROS Melodic

Anything else?

No response

Myzhar commented 2 years ago

@Srijal97 thank you for reporting. The bug is fixed