stereolabs / zed-ros-wrapper

ROS wrapper for the ZED SDK
https://www.stereolabs.com/docs/ros/
MIT License
447 stars 391 forks source link

camera_id not exposed through launchfiles (zedx, zedxm) #886

Closed bmegli closed 1 year ago

bmegli commented 1 year ago

Preliminary Checks

Proposal

Should expose camera_id and pass it down to zed_camera.launch.xml

This is necessary for multi GMSL2 camera scenario.

Use-Case

Working with multiple GMSL2 cameras:

roslaunch zed_wrapper zedx.launch camera_id:=0
roslaunch zed_wrapper zedxm.launch camera_id:=1

Anything else?

The fix is straightforward.

I am already using and I may supply pull request (not worth it probably for such simple change).

Myzhar commented 1 year ago

@bmegli the parameter is now exposed: https://github.com/stereolabs/zed-ros-wrapper/blob/master/zed_wrapper/launch/zedx.launch#L28

Let me know if it works as expected

bmegli commented 1 year ago

Thank you @Myzhar

Now I can run multiple GMSL2 cameras on single system

image