stereolabs / zed-ros2-wrapper

ROS 2 wrapper for the ZED SDK
https://www.stereolabs.com/docs/ros2/
Apache License 2.0
159 stars 163 forks source link

Documentation doesn't provide correct git clone command #108

Closed KohlhardtC closed 2 years ago

KohlhardtC commented 2 years ago

Preliminary Checks

Description

The Getting Started with ROS 2 and ZED does not show the correct clone command in the Build the package section. The command is missing the recursive option.

The correct clone command is: git clone --recursive https://github.com/stereolabs/zed-ros2-wrapper.git

On a side note, it might help some new users to remind them to source their ROS2 environment before attempting to run rosdep

Steps to Reproduce

  1. Follow the documentation to build the pacakge
  2. ...

Expected Result

The package builds

Actual Result

rosdep and colcon build fails because the recursive option is not in the clone command

ZED Camera model

ZED2i

Environment

Ubuntu 20.04
Jetson Orin AGX
ROS2/Foxy

Anything else?

No response

Myzhar commented 2 years ago

Hi @KohlhardtC thank you for reporting

Myzhar commented 2 years ago

The online documentation is updated now