search

stereolabs / zed-ros2-wrapper

ROS 2 wrapper for the ZED SDK
https://www.stereolabs.com/docs/ros2/
Apache License 2.0
134 stars 139 forks source link

Add more modularity in Jetson Dockerfiles #216

Closed dylan-gonzalez closed 3 days ago

dylan-gonzalez commented 1 month ago

It didn't make sense to me why some of the ARGS in the Dockerfiles weren't be used for the base image, so I've added support for that - not sure if there was originally a reason to not do this?

I've also updated the L4T args to reflect the latest versions available.

I've only done this for the L4T Dockerfiles as I'm currently only using this repo with a jetson xavier nx.

dylan-gonzalez commented 1 month ago

BTW, I didn't realise this about ARGS declared after FROM.

I've made a commit that fixes this, but it's a bit ugly; not sure if there's a better way to do it. I saw with multi-stage builds that you can inject args directly into some stages, but I might take a look at this later.

github-actions[bot] commented 1 week ago

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment otherwise it will be automatically closed in 5 days