search

stereolith / fints-to-ynab

Import transactions from FinTS-capable banks to YNAB
19 stars 4 forks source link

Crash when importing transactions #1

Closed neustifter closed 3 years ago

neustifter commented 3 years ago

When I want to import transactions from the comdirect bank I get the following stacktrace.

I try to set it up on my synology DSM with pyhton 3.8.1.

Traceback (most recent call last): File "fints_to_ynab.py", line 56, in transactions = fints_importer.get_transactions(bank_config) File "/volume1/homes/chefkoch/FinTS YNAB Importer/fints_importer.py", line 46, in get_transactions return list(map(lambda t: transform_fints_transaction(t.data, parse_paypal=bank_config.parse_paypal), transactions)) File "/volume1/homes/chefkoch/FinTS YNAB Importer/fints_importer.py", line 46, in return list(map(lambda t: transform_fints_transaction(t.data, parse_paypal=bank_config.parse_paypal), transactions)) File "/volume1/homes/chefkoch/FinTS YNAB Importer/fints_importer.py", line 19, in transform_fints_transaction cash_withdrawl= True if "BARGELD" in transaction['posting_text'] else False TypeError: argument of type 'NoneType' is not iterable

stereolith commented 3 years ago

Could reproduce this with my own Comdirect account. The issue was that the 'posting_text'-field in the finTS transaction is emtpy in the Comdirect transactions (could only test with one transaction though). This could mean that the cash withdrawl detection function could not work for you.

Added handling of that empty field in https://github.com/stereolith/fints-to-ynab/commit/3c5af8b606454e184f5f81fb25a9a5a100ea4f7a , on current master. Please test.

neustifter commented 3 years ago

Tested with 3c5af8b and it worked.