search

stereum-dev / ethereum-node

Run an Ethereum node, solo stake ETH and connect dApps to your server with Stereum Ethereum Node Setup & Manager!
https://www.stereum.com/?utm_source=github&utm_medium=stereum-repo&utm_id=0
MIT License
122 stars 48 forks source link

[Bug]: Erigon setup fails #2089

Open stefa2k opened 1 month ago

stefa2k commented 1 month ago

Environment

Release

Bug Description

Erigon tag is set to

image: thorax/erigon:v2.60.8

correct one is

image: thorax/erigon:2.60.8

possibly related to https://github.com/stereum-dev/ethereum-node/issues/2052

Launcher Version

2.2.2

Operating System

Mac

Affected Service (if applicable)

Erigon 2.60.8

Logs (if applicable)

No response

Acknowledgment

daverolo commented 1 month ago

possibly related to #2052

Confirmed

Erigon tag is set to image: thorax/erigon:v2.60.8

Absolutely unclear for me how this could be. The updates.json has the correct tag 2.60.8 and therefore I would expect a working image: thorax/erigon:2.60.8.

Erigon has changed their release repo to erigontech/erigon but the images are still also available on the old thorax/erigon repo.

Problem 1

updates.json correctly sets the tag without v since version 2.60.7 but the image in launcher/src/backend/ethereum-services/ErigonService.js is still thorax/erigon.

To fix this issue we need at least to change the image to erigontech/erigon in ErigonService.js and write playbooks for the Stereum release to adjust existing nodes.

@NeoPlays since this is the same as the SSV image change for mainnet in #2090, it makes probably sense to apply the playbooks patch for both in the same release.

Problem 2

It is unclear how @stefa2k could end up with a v2.60.8 tag while the updates.json tag is correct 2.60.8.

stefa2k commented 1 month ago

Just had it happen again

NeoPlays commented 1 month ago

Just had it happen again

The old repo didn't provide multiarch images, which forced us to use special arm tags for erigon. These images tho didn't use the v before the version and then normal ones did until some recent version. So Stereum is adding them if not present. But with the new image we can delete this behaviour completly :)