search

sterin / vscode-xcodebuild-tools

Work with Xcode projects from inside Visual Studio Code
MIT License
57 stars 9 forks source link

Add support for multiple configs #5

Closed amatosov-rbx closed 5 years ago

amatosov-rbx commented 5 years ago

This change allows having array of configurations or a single configuration in xcodebuild-tools.json UI picker is provided to switch active configuration (workspace/scheme)

sterin commented 5 years ago

Hi Anaton,

Thanks for the PR. Would you mind making some changes and resubmit?

  1. I've made a bit of a mess in the history by rebasing your previous PR. Could you graft your changes into the current master? Sorry for that.

  2. I have no idea how many users are using the extension, but I would rather not break backward compatibility. Could you check for the existing settings and add them as an additional configuration if possible.

  3. I think there's no need for a "configuration" field and "configurationArray". I think just a single array "configurations" might work.

Thanks, Baruch

amatosov-rbx commented 5 years ago

Hi @sterin,

  1. I'll do the clean rebase
  2. These changes are backward compatible
  3. This is needed for backward compatibility
sterin commented 5 years ago

Hi @amatosov-rbx,

Great. So the "oneOf" refers to the top-level element giving the choice between a top-level array and an object, right?

amatosov-rbx commented 5 years ago

Correct. oneOf is well explained here https://json-schema.org/understanding-json-schema/reference/combining.html

amatosov-rbx commented 5 years ago

I have found couple issues with this PR, I'll reopen it once I have the proper fix

amatosov-rbx commented 5 years ago

Re-open didn't work because of rebase. Opened new PR https://github.com/sterin/vscode-xcodebuild-tools/pull/6