search

sterner-stuff / private-wordpress-plugin-composer-provider

A starter template for a self-updating GitHub mirror of a private WordPress library for use via Composer.
40 stars 6 forks source link

change move command to also move any dotfiles in unzipped directory, … #7

Closed oliward closed 2 years ago

oliward commented 2 years ago

…else rm will fail

Found this out when an unzipped package.zip created a folder with files such as:

plugin-directory/.idea/php.xml
plugin-directory/.gitignore
plugin-directory/.vscode/launch.json

The action will then fail at the rm step with a permission denied.

Alternative is to change rm command to sudo rm but I suppose there might be plugins that have a reason to have dotfiles within their directory, so should be moved and committed...

ethanclevenger91 commented 2 years ago

@oliward The command you proposed caused non-0 exit codes, which I'd prefer to avoid entirely rather than ignore. Can you test the latest version on this PR that uses shopt instead?

oliward commented 2 years ago

@ethanclevenger91 this works nicely thank you.

Are you happy to merge now?