sterodium / selenium-grid-extensions

Set of Selenium Grid extensions for a better UI tests.
Apache License 2.0
46 stars 23 forks source link

Convenience Sikuli client factory method #29

Closed buzdin closed 6 years ago

buzdin commented 9 years ago

The following code is too complex

String sessionId = remoteWebDriver.getSessionId();
SikuliExtensionClient client = new SikuliExtensionClient(host, port, sessionId);

Create factory method, which builds Sikuli client on RemoteWebDriver object instance without the need to pass any other parameters.

echoAlexey commented 9 years ago

This will require to bring dependency on selenium-server in sikuli client only for passing Driver to constructor. I suggest to leave constructor as it is.

volkovs commented 9 years ago

@echoAlexey I agree it looks like extra step from user's point of view. Also looks like not a big issue, since client already has dependency on selenium-server (it creates RemoteWebDriver in the first place). If you don't want to make this dependency propagated we can set the scope to provided. What do you think?

echoAlexey commented 9 years ago

Agree, will include in next release. Will look into optional scope for it.