search

steroid-team / app

Helping you organise your day with ease and privacy.
1 stars 2 forks source link

Feature/Task Renaming & Deletion improvement (with the work of Leandro: PR111) #112

Closed theo-damiani closed 3 years ago

theo-damiani commented 3 years ago

Hey!

Thank you to Leandro for his work. (so maybe we can close his PR #111, his work is in this one also) I just adapt it and tried to make it as close as possible to what Yago showed us last time:

You have to long click on a task and it opens an edit text. So you can rename it if you want. You close the modification layout by pressing one of the two buttons. The green one is to save your modification and the red is to delete the task.

Just one remark to think of. It's that whenever you push the green button you go through the view model, the repository, and the database, even if you didn't change anything so maybe I will add a check to verify the user indeed rename the task.

1 2 3 4

And also I removed the deletion from this button, I don't know if you prefer to keep it also: 5

YagoGG commented 3 years ago

And also I removed the deletion from this button, I don't know if you prefer to keep it

+1 to removing it.

theo-damiani commented 3 years ago

Thank you for your review Yago!

Sure you right it's better to be able to modify only one task at a time.

And yes I wanted to have the same font size but I didn't know it was possible to remove the underline!

I will push the changes!

theo-damiani commented 3 years ago

Thanks! Yes, I tested your commit 079de723380c248de8a1e7443d48ce4964f051b7 and it really improved the user experience, good feature !

YagoGG commented 3 years ago

+1 to get this merged for now.

@lgraziano, could you please file an issue with the steps to reproduce the behaviour with the checkboxes? That way we can keep track of it in the future.

Cheers!