search

steroid-team / app

Helping you organise your day with ease and privacy.
1 stars 2 forks source link

Feature/check task #145

Closed theo-damiani closed 3 years ago

theo-damiani commented 3 years ago

Hey! So in this PR, I added the logic to manage the boolean Done of a task. I also refactor the way we delete/modify tasks because, in a previous way, there are a lot of problems when you scroll for example if you have a lot of tasks. And also now when you click on a task, it opens a small panel to update it. And so it will be easier to add features for the future. For example, I wanted to add a boolean "prioritize" so when a task has this flag it is displayed on the list selection view.

I also try to add design according to what Yago did.

theo-damiani commented 3 years ago

Tested it and it looks very nice!

One thing I noticed, when the panel is opened after clicking a task, it is not small on my emulator, it takes all the free space. There was also the idea of having the Todo go to the bottom when getting marked as done but I think it looks great as is.

Thanks, @VPellenc for the review! Normally the panel looks like this: 1

Could you confirm for me that you have the same thing? This is not a dialog so yes it was built to take a big part of the screen (the same as the recycler view).

Yes, I didn't implement the logic to move a task to the bottom when it is done, because I will prefer to implement this in a PR that takes care of all the sorting aspect of a task as it is quite the same thing.

VPellenc commented 3 years ago

Tested it and it looks very nice! One thing I noticed, when the panel is opened after clicking a task, it is not small on my emulator, it takes all the free space. There was also the idea of having the Todo go to the bottom when getting marked as done but I think it looks great as is.

Thanks, @VPellenc for the review! Normally the panel looks like this: 1

Could you confirm for me that you have the same thing? This is not a dialog so yes it was built to take a big part of the screen (the same as the recycler view).

Yes, I didn't implement the logic to move a task to the bottom when it is done, because I will prefer to implement this in a PR that takes care of all the sorting aspect of a task as it is quite the same thing.

Yes I have the same thing. It looks a bit weird with the empty space until the Delete button but it's definitely not a blocker. I could imagine it as an "extension" of an item in the recyclerView, where you can still see the other tasks around but I don't know how hard it would be to implement (if even possible). Either way I think it looks good enough for now.

theo-damiani commented 3 years ago

Yes I have the same thing. It looks a bit weird with the empty space until the Delete button but it's definitely not a blocker. I could imagine it as an "extension" of an item in the recyclerView, where you can still see the other tasks around but I don't know how hard it would be to implement (if even possible). Either way I think it looks good enough for now.

I designed that way because I thought that we will have space to add more features: like add categories to a task, add a boolean to know if a task is important, ...

theo-damiani commented 3 years ago

Is it okay if we merge this PR?

VPellenc commented 3 years ago

Yes I have the same thing. It looks a bit weird with the empty space until the Delete button but it's definitely not a blocker. I could imagine it as an "extension" of an item in the recyclerView, where you can still see the other tasks around but I don't know how hard it would be to implement (if even possible). Either way I think it looks good enough for now.

I designed that way because I thought that we will have space to add more features: like add categories to a task, add a boolean to know if a task is important, ...

Yeah I see in that case my alternative makes less sense

Is it okay if we merge this PR?

Good for me