search

steroid-team / app

Helping you organise your day with ease and privacy.
1 stars 2 forks source link

Feature/todo list controller #46

Closed VPellenc closed 3 years ago

VPellenc commented 3 years ago

I created this draft to get feedback on the comments I put in the code, and for the general structure of the controller.

Once everything is clear i'll clean up comments, add the tests, and make a proper PR.

VPellenc commented 3 years ago

I removed the getTask, and added tests.

The coverage for this patch isn't at 100%, it should be at 82%. The reason being that e.printStackTrace() can't really be properly tested. I could add a test to run that code if needed but not sure if it's a good idea. I'm open to other suggestions as well.

theo-damiani commented 3 years ago

Hey, if you agree @VPellenc, I think we can close this PR.

VPellenc commented 3 years ago

Yup