search

steroid-team / app

Helping you organise your day with ease and privacy.
1 stars 2 forks source link

Adding the rename function in the ListSelectionActivity #77

Closed shoutizix closed 3 years ago

shoutizix commented 3 years ago

Hey guys !

This addresses the issue #66 I had to refactor a bit the code and implement an adapter like we used for the ItemViewActivity class. I have also changed the ScrollView that contained TextView by a ListView containing TextView since it was better to get which view was cliked on and modify/open the corresponding TodoList. I think that #59 should be pretty easy using the adapter I've added in this PR.

I still have to add tests and use the Database but otherwise the rename functionality should work great !

shoutizix commented 3 years ago

Now all should be great ! I'm waiting for your reviews :)

shoutizix commented 3 years ago

Hey !

You're absolutely right on the points that you've mentioned, I've made the corresponding changes.

YagoGG commented 3 years ago

Please do not forget to update the branch with the latest master to make sure that there are no merge conflicts. Thanks a lot! :)

shoutizix commented 3 years ago

Yes sure sorry I resolve the conflict now it should be good to merge !

theo-damiani commented 3 years ago

Again maybe the alert dialog will cause some errors. But works fine for me.

Edit: I will need this PR to work on my task for this sprint.