chore: Fix (almost) all the linter warnings

steroid-team / app

Helping you organise your day with ease and privacy.

1 stars 2 forks source link

chore: Fix (almost) all the linter warnings #79

Closed YagoGG closed 3 years ago

YagoGG commented 3 years ago

This resolves the issues in our codebase that make the linter unhappy.

The only ones that I have not fixed are related to the app's theme/colours, mostly because they would involve removing the theme and we are going to need it for the visual revamp.

Fixes #53.

sydneyhauke commented 3 years ago

These conflicts on the FirebaseUIActivity class... may be a result of the recent merging of PR related to issue #50 ?

YagoGG commented 3 years ago

I just updated the PR with the latest master and solved the merge conflicts. Thanks for both the review and the heads up, @sydneyhauke!

VPellenc commented 3 years ago

I got AAPT: error: resource drawable/ic_launcher_foreground (aka com.github.steroidteam.todolist:drawable/ic_launcher_foreground) not found. while trying to test in on the emulator.

Following the advice here: https://stackoverflow.com/questions/49420636/drawable-ic-launcher-foreground-not-found-how-to-find-that-xml-file I added a new line to the file and that made it work. I don't know if anyone else has the same issue but if so a change is needed I guess