Closed VPellenc closed 3 years ago
Yes, that makes sense, let's do that in the next sprint. For this PR I will probably just add the tests and then focus my time to do some reviewing.
There should be one more test, to check that clicking on the save button actually makes the Note persist, however I don't have the time to add it before 7pm so I ready the PR for review now.
@VPellenc, could you please solve the merge conflicts?
Pinging @sydneyhauke, as I believe that the changes requested have already been taken care of.
I believe the work of this PR is going to be more or less replaced by #151 so it looks to me we should probably close this PR. I don't know how that will stand with respect to #149 however since originally my PR was considered as a dependency. Do we now consider #151 to be the dependency to #149 ?
I believe the work of this PR is going to be more or less replaced by #151 so it looks to me we should probably close this PR. I don't know how that will stand with respect to #149 however since originally my PR was considered as a dependency. Do we now consider #151 to be the dependency to #149 ?
I need that the database handle note so I think yes.
Let's close this PR. issue #151 already handles that.
This also has the content of my other PR (the view) as it is a required dependency.
This implemented the Note related actions in the VolatileDatabase, and added a minimal (and to be replaced later) integration with the view.
What you can do in this draft:
What am I going to do: