search

steroid-team / app

Helping you organise your day with ease and privacy.
1 stars 2 forks source link

Feature/async todorepository #86

Closed shoutizix closed 3 years ago

shoutizix commented 3 years ago

Hey guys !

For now I was only able to make the putTask and the removeTask asynchronous, but on my smartphone it works great. We definitely will have to make asynchronous ALL the database part in the other sprints, but for this one I think this is already something that we could merge. Let me know your opinions ! :)

shoutizix commented 3 years ago

Codeclimate is detecting code duplicate but in fact it's not the same as it is the attributes of 2 differents classes

shoutizix commented 3 years ago

Hey @sydneyhauke thanks a lot for the review !

This PR is linked to the issue #69 and I think that the description was to exactly to be able to call the operations synchronously but there will be done in background, in this way I think that what I've done is right.

But it's true that to create an AsyncTask every time isn't the most optimal way to do that but it was the easier way to begin with.

I also think that we should consider for the next sprints what you've mentionned to use futures.

YagoGG commented 3 years ago

As per the team standup (12/04/2021), this is being superseded by @sydneyhauke's work on data persistence.