Delete whitelist entry fails

[mellingham]

Describe the bug Unable to delete a whitelist entry from Android app.

To Reproduce Steps to reproduce the behavior:

1. Go to WHITELIST
2. Swipe left on whitelist entry to reveal delete button
3. Tap delete button
4. Entry does not delete

Expected behavior Expect the whitelist entry to be deleted when swiping left and tapping the delete button.

Screenshots If applicable, add screenshots to help explain your problem.

Versions (please complete the following information):

• Pi-hole version: 5.1
• FlutterHole version: 5.2.3

Additional context Add any other context about the problem here.

[tom-greene]

Exact same problem with the same configuration. I do have 2 pi-hole servers in my config however.

[sterrenb]

Hello @mellingham & @tom-greene 👋👋 - Thanks for opening an issue!

Could you try the following using a browser to figure out your Pi-hole's responses:

1. In the web dashboard, add a domain to the whitelist called "testing" (not as a wildcard or regex).
2. Once added, try to remove it via the API by using this in a browser (adjust to your Pi-hole): http://pi.hole/admin/api.php?list=white&sub=testing&auth=MY_API_TOKEN It should return a simple JSON response.
3. Assuming step 2 succeeded, refresh your web dashboard, it should be gone.

Please share the response of the API query or where things go wrong, and we can hopefully figure out the culprit.

[mellingham]

Hi all.

{"Success":true, "message":null}

And the entry has deleted ok. Is it possibly a UI problem? The delete button slides closed when tapped so its like the delete is not even being called?

Cheers for the help.

Get Outlook for Androidhttps://aka.ms/ghei36

---

From: Thomas notifications@github.com Sent: Friday, September 11, 2020 9:42:09 AM To: sterrenburg/flutterhole flutterhole@noreply.github.com Cc: Software Subscription Aliases software@highq.co.nz; Mention mention@noreply.github.com Subject: Re: [sterrenburg/flutterhole] Delete whitelist entry fails (#116)

Hello @mellinghamhttps://github.com/mellingham & @tom-greenehttps://github.com/tom-greene 👋👋 - Thanks for opening an issue!

Could you try the following using a browser to figure out your Pi-hole's responses:

1. In the web dashboard, add a domain to the whitelist called "testing" (not as a wildcard or regex).
2. Once added, try to remove it via the API by using this in a browser (adjust to your Pi-hole): http://pi.hole/admin/api.php?list=white&sub=testing&auth=MY_API_TOKEN It should return a simple JSON response.
3. Assuming step 2 succeeded, refresh your web dashboard, it should be gone.

Please share the response of the API query or where things go wrong, and we can hopefully figure out the culprit.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/sterrenburg/flutterhole/issues/116#issuecomment-690747367, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANFA7BSSLKUB3T6WXZPFJG3SFFB3DANCNFSM4QPPTCCQ.

[tom-greene]

I got the same answer as @mellingham and additionally it deleted.

{"success":true,"message":null}

I would tend to agree that it's likely just not calling the URI when selecting the delete function.

[sterrenb]

Alright, your Pi-holes' APIs seem to work fine.

Does the Alice API log (in the app) show any requests that perform the API call when you use the button? That seems to be the case, but just double-checking.

Will take a look at the slidable implementation sometime, I bet the culprit is around there.

[tom-greene]

I created a testing whitelist entry and tried to delete it. The API log does not show an entry for the removal.

On Sun, Sep 13, 2020, 05:45 Thomas notifications@github.com wrote:

Alright, your Pi-holes' APIs seem to work fine.

Does the Alice API log (in the app) show any requests that perform the API call when you use the button? That seems to be the case, but just double-checking.

Will take a look at the slidable implementation sometime, I bet the culprit is around there.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sterrenburg/flutterhole/issues/116#issuecomment-691654931, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMAKUDQTKDTEGQZKSZ33PO3SFSPDJANCNFSM4QPPTCCQ .

[mellingham]

Same result here.

Get Outlook for Androidhttps://aka.ms/ghei36

---

From: tom-greene notifications@github.com Sent: Monday, September 14, 2020 2:18:40 AM To: sterrenburg/flutterhole flutterhole@noreply.github.com Cc: Software Subscription Aliases software@highq.co.nz; Mention mention@noreply.github.com Subject: Re: [sterrenburg/flutterhole] Delete whitelist entry fails (#116)

I created a testing whitelist entry and tried to delete it. The API log does not show an entry for the removal.

On Sun, Sep 13, 2020, 05:45 Thomas notifications@github.com wrote:

Alright, your Pi-holes' APIs seem to work fine.

Does the Alice API log (in the app) show any requests that perform the API call when you use the button? That seems to be the case, but just double-checking.

Will take a look at the slidable implementation sometime, I bet the culprit is around there.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sterrenburg/flutterhole/issues/116#issuecomment-691654931, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMAKUDQTKDTEGQZKSZ33PO3SFSPDJANCNFSM4QPPTCCQ .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/sterrenburg/flutterhole/issues/116#issuecomment-691677321, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANFA7BSTKGBY2GPKJKFHBU3SFTIEBANCNFSM4QPPTCCQ.