search

sterrenb / flutterhole

A third party Android application for the Pi-Hole® dashboard.
https://play.google.com/store/apps/details?id=sterrenburg.github.flutterhole
MIT License
401 stars 27 forks source link

Pi-hole with hidden domains breaks domains page #164

Open brandonio21 opened 1 year ago

brandonio21 commented 1 year ago

Describe the bug I have domains hidden on my pi-hole (privacy level 1). When going to the "domains" page on the Flutterhole app, I get the error "fetchTopItems failed with unexpected error" - I've confirmed it's due to my privacy settings (tab works fine when privacy is disabled)

The page should probably have a more clear error message.

To Reproduce Steps to reproduce the behavior:

  1. In the pi-hole admin panel, select the privacy option "Hide domains: Display and store all domains as "hidden""
  2. Go to the domains tab in Flutterhole

Expected behavior A message saying "this tab doesn't work since domain tracking is disabled" or some other more informative message.

Screenshots

Screenshot_20221016-223817

Versions (please complete the following information):

sterrenb commented 1 year ago

Thank you for the report! I have never tried changing the privacy level on my on Pi-hole, so this has never been tested. Will look into this in a future release. My assumption is that the (undocumented) Pi-hole API returns some unexpected result that is not parseable by the internal models.