search

sterrenb / flutterhole

A third party Android application for the Pi-Hole® dashboard.
https://play.google.com/store/apps/details?id=sterrenburg.github.flutterhole
MIT License
400 stars 27 forks source link

Flutterhole https requests doesn't follow subdir in https path #85

Open QBANIN opened 4 years ago

QBANIN commented 4 years ago

Describe the bug My pihole https path is configured like https://mypiholeserver.com/pihole but flutterhole doesn't folow /pihole path and all http request are sent to https://mypiholeserver.com/

To Reproduce Steps to reproduce the behavior:

  1. Configure your pihole adress into https://mydomain/subdir path
  2. Create new pihole server in flutterhole
  3. Validate button doesn't work (clicking does nothing)
  4. After saving new setup dashboard is empty
  5. Api log show pihole endpoint /pihole:443/admin/api.php but it doesn't seem to be true. I can see that response contains https://mypiholeadress (without /pihole) data.

Versions (please complete the following information):

sterrenb commented 4 years ago

Hello @QBANIN 👋 - Thanks for opening an issue!

If I understand correctly, is the /pihole subdirectory a part of the Base URL, or the API path (in the app settings)? It might be worth trying to put the subdirectory at the start of the API path.

My own Pi-hole lives in a root directory without SSL, so it could very well be that there are bugs with other kinds of setups. Issue #84 might be relevant too.

QBANIN commented 4 years ago

Hi @sterrenburg . It is part of Base URL. I moved /pihole to API path but it still wasn't working. I had to remove /admin as well an it works just fine now...

Pre-v5 Flutterhole worked just fine with this setup without this workaround.

sterrenb commented 4 years ago

Ok, thank you for the confirmation. Will into it!