search

sterrenb / flutterhole

A third party Android application for the Pi-Hole® dashboard.
https://play.google.com/store/apps/details?id=sterrenburg.github.flutterhole
MIT License
400 stars 27 forks source link

DNS spikes cause graphs to be unreadable #97

Open djh82 opened 4 years ago

djh82 commented 4 years ago

Screenshot_20200613-100953

As can be seen in the attached picture, a DNS spike causes the axis labels to be unreadable.

Using pihole 5 with flutterhole 5.1.2.

djh82 commented 4 years ago

Maybe kHorizontalLineInterval should be dynamically calculated based on the largest value - then you could guarantee how many labels were present for every graph ever displayed?

djh82 commented 4 years ago

Awesome app BTW!

sterrenb commented 4 years ago

Hello @davidhart82 👋 - Thanks for opening an issue!

That is indeed one bad looking graph.

Maybe kHorizontalLineInterval should be dynamically calculated based on the largest value - then you could guarantee how many labels were present for every graph ever displayed?

That is a good idea. The graph implementation is quite messy and partially hardcoded, so there is some room for improvement. Will look into making the horizontal step size dynamic.