issues
search
stery28
/
devschool-homeworks
ING {Dev}School - Java Edition
0
stars
0
forks
source link
FE-CSS
#7
Open
BogdanArvinte
opened
5 years ago
BogdanArvinte
commented
5 years ago
Nice! 😃
Some feedback:
as a
best practice
fonts should also include format
https://github.com/cosmin-sterian/devschool-homeworks/blob/a5e83b4c77ac3c1dbc21ff23d8c01786469b8e41/frontend/session-2/style.css#L3
also a best practice is to use a container for
max-width
instead of applying it on the
body
https://github.com/cosmin-sterian/devschool-homeworks/blob/a5e83b4c77ac3c1dbc21ff23d8c01786469b8e41/frontend/session-2/style.css#L10
Nice! 😃
Some feedback:
max-widthinstead of applying it on thebodyhttps://github.com/cosmin-sterian/devschool-homeworks/blob/a5e83b4c77ac3c1dbc21ff23d8c01786469b8e41/frontend/session-2/style.css#L10