search

stetelepta / oohembed

Automatically exported from code.google.com/p/oohembed
Other
7 stars 0 forks source link

dotSUB calls return incorrect embed code #12

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Open 
http://oohembed.com/oohembed/?url=http%3A//dotsub.com/view/10e3cb5e-96c7-
4cfb-bcea-8ab11e04e090
2. Look at embed code

What is the expected output? What do you see instead?

The html portion should be an iframe not an embed tag

I work at dotSUB. While we plan to add embed/object tag support soon, we do 
have some know 
bugs at the moment.

Original issue reported on code.google.com by brooks.l...@gmail.com on 19 Apr 2010 at 1:26

GoogleCodeExporter commented 9 years ago 
Two points:

1. I implemented what was reported as expected output in issue #11  If you 
believe 
the output should be different, please give the exact output.

2. You would be the first person to ask for iframe wrapping in the response. 
The spec 
(oembed.com) suggests that consumers should be the ones wrapping the response 
in an 
iframe if they fear XSS attacks.

So my question is, why do you think the html portion should be an iframe?

Original comment by deepak.s...@gmail.com on 20 Apr 2010 at 12:27

GoogleCodeExporter commented 9 years ago 
We wrap in a iFrame due to having not ported all our player features from the 
first version of our player. You'll 
note our sites embed code is an iFrame. 

It will remain this way while we fix the remaining issues. Due to your service 
sending users an embed tag we get 
complaints to our help desk. 

We are implementing oEmbed on our site in the next few days anyways. This again 
will return an iFrame until we 
can fix these issues.

Original comment by brooks.l...@gmail.com on 20 Apr 2010 at 12:31

GoogleCodeExporter commented 9 years ago 
Okay.. changed it to return an iframe in r21f2b96c1a
Please check it out.

Original comment by deepak.s...@gmail.com on 20 Apr 2010 at 10:34

GoogleCodeExporter commented 9 years ago 
Thanks!

We also now offer oEmebed from dotSUB. http://solutions.dotsub.com/oEmbed

Original comment by brooks.l...@gmail.com on 20 Apr 2010 at 1:25

GoogleCodeExporter commented 9 years ago 
gah.. you said "next few days" to implement oEmbed but took just one day! If I 
had 
known, I wouldn't have done the iframe fix and just used your oembed endpoint 
:-)

Seriously though, if an upstream provider has an oembed endpoint, I use that 
and also 
pass along any extra parameters like maxwidth, etc. Will be doing that soon.

Original comment by deepak.s...@gmail.com on 21 Apr 2010 at 1:57

GoogleCodeExporter commented 9 years ago 
Sorry about that Deepak, it was easier to implement than I thought. We also 
have some dotSUB specific 
parameters that can be passed.

Original comment by brooks.l...@gmail.com on 21 Apr 2010 at 2:38

GoogleCodeExporter commented 9 years ago 
Migrated to dotsub's own oembed endpoint.

Original comment by deepak.s...@gmail.com on 19 Nov 2010 at 2:02