search

stetelepta / oohembed

Automatically exported from code.google.com/p/oohembed
Other
7 stars 0 forks source link

type=video for slideshare #13

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. http://oohembed.com/oohembed/?
url=http%3A//www.slideshare.net/igniteportland/how-to-run-a-startup-without-
losing-your-mind
2.
3.

What is the expected output? What do you see instead?
I expected type=rich, however i see type=video instead. Is this intended?

Original issue reported on code.google.com by yousefda...@gmail.com on 20 Apr 2010 at 10:07

GoogleCodeExporter commented 9 years ago 
Yeah. It probably should be "rich" and not "video". Just that as far as embed 
behaviour is concerned, it acts just like videos so I figured, why not.

I'll change it if it's actually breaking something.

Original comment by deepak.s...@gmail.com on 20 Apr 2010 at 10:36

GoogleCodeExporter commented 9 years ago 
Problem in this case is that I would like people on my website to be able to 
search for 
certain type of links (and use oembed type for this). If the user searches for 
videos 
the best experience would be for slideshare rich content not to show up.

Original comment by yousefda...@gmail.com on 20 Apr 2010 at 10:49

GoogleCodeExporter commented 9 years ago 
Fair enough. I'll push this fix as part of couple of other fixes. No urgency I 
hope!

Original comment by deepak.s...@gmail.com on 20 Apr 2010 at 12:06

GoogleCodeExporter commented 9 years ago 
Done in r61e1f0fe57.

Original comment by deepak.s...@gmail.com on 20 Apr 2010 at 12:45