search

stevahnes / figma-plugins

📌 Single repository containing all my Figma plugins
https://www.figma.com/@stevahnes
MIT License
13 stars 3 forks source link

Some elements are flipping #13

Open aarondewald opened 3 years ago

aarondewald commented 3 years ago

Great plugin, love it.

One small issue. When we use the plugin, some elements are being vertically flipped. Is there any trick where w can clone without having to go back and re-flip everything in the cloned page?

Screen Shot 2021-02-03 at 6 17 45 AM

stevahnes commented 3 years ago

Hi @aarondewald thanks for using my plugin! I am so sorry it did this! I will try to get to the bottom of this... If it's okay with you, do you mind sharing the structure of the buttons? I want to replicate the issue so that I can get to the bottom of it :)

aarondewald commented 3 years ago

Hi Sevanus, No worries, it's a handy little tool.

It's sitting in a container that looks like this: Screen Shot 2021-02-03 at 6 36 30 AM

It renders like this... Screen Shot 2021-02-03 at 6 35 17 AM

Anything that's in the CTA auto-layout layer is flipped. We have a variant that contains some text, that gets flipped too.

Thanks again!

stevahnes commented 3 years ago

Thanks for the elaboration! I'll try to fix it ASAP :) Aiming to start debugging tomorrow! /Steve

stevahnes commented 3 years ago

Hi @aarondewald, I tried recreating the structure based on your screengrab, and I was unable to reproduce the issue: https://www.figma.com/file/wf4IDwjoSsksaBxKSZjtKV/PageClone-Debugging?node-id=2%3A2&viewport=519%2C350%2C1 Nonetheless, I have a feeling that I may not have the exact properties as per your design. I am not sure how feasible this is, but is there a chance you can share with me a separate copy of a file containing the problematic design elements? If I can't reproduce it, it's quite difficult for me to debug it properly. You can find my Figma email in my GitHub profile: https://github.com/stevahnes/ Thanks again!

stevahnes commented 3 years ago

Hi @aarondewald, I believe the issue is still recurring to you? If yes I really need to be able to replicate it in order to find the root cause. Otherwise, I can't fix it as it works fine in our mockups, both work ones and my personal ones.

aarondewald commented 3 years ago

Ah! Thanks for following up - I lost track of things. Let me work on getting you a copy so you can see exactly what they are.

On Feb 14, 2021, at 11:52 PM, Stevanus Satria notifications@github.com wrote:

Hi @aarondewald https://github.com/aarondewald, I believe the issue is still recurring to you? If yes I really need to be able to replicate it in order to find the root cause. Otherwise, I can't fix it as it works fine in our mockups, both work ones and my personal ones.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/stevahnes/figma-plugins/issues/13#issuecomment-778993184, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUDJMEW4KO4D4WOMT2ZIP3S7DADJANCNFSM4XA2ZS6Q.

stevahnes commented 3 years ago

Ah! Thanks for following up - I lost track of things. Let me work on getting you a copy so you can see exactly what they are.

On Feb 14, 2021, at 11:52 PM, Stevanus Satria notifications@github.com wrote:

Hi @aarondewald https://github.com/aarondewald, I believe the issue is still recurring to you? If yes I really need to be able to replicate it in order to find the root cause. Otherwise, I can't fix it as it works fine in our mockups, both work ones and my personal ones.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/stevahnes/figma-plugins/issues/13#issuecomment-778993184, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUDJMEW4KO4D4WOMT2ZIP3S7DADJANCNFSM4XA2ZS6Q.

Hello @aarondewald, have not heard from you in a while! I believe the issue is still there? Is it possible to get the sample file? And if it's still reproducible do you observe it in all of your prototypes?

aarondewald commented 3 years ago

Yes, and I’ve actually encountered some other issues happening as well:

Components are flipping vertically Transparency is not maintained Rare, but sometimes the layout massively changes.

This occurs when something is a component and we clone while deleting hidden layers and locking the objects

Can you reach out to me privately so I can invite you to our project for review?

On Mar 11, 2021, at 2:10 AM, Stevanus Satria @.***> wrote:

Ah! Thanks for following up - I lost track of things. Let me work on getting you a copy so you can see exactly what they are.

On Feb 14, 2021, at 11:52 PM, Stevanus Satria @. @.> wrote:

Hi @aarondewald https://github.com/aarondewald https://github.com/aarondewald https://github.com/aarondewald, I believe the issue is still recurring to you? If yes I really need to be able to replicate it in order to find the root cause. Otherwise, I can't fix it as it works fine in our mockups, both work ones and my personal ones.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub #13 (comment) https://github.com/stevahnes/figma-plugins/issues/13#issuecomment-778993184, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUDJMEW4KO4D4WOMT2ZIP3S7DADJANCNFSM4XA2ZS6Q https://github.com/notifications/unsubscribe-auth/ABUDJMEW4KO4D4WOMT2ZIP3S7DADJANCNFSM4XA2ZS6Q.

Hello @aarondewald https://github.com/aarondewald, have not heard from you in a while! I believe the issue is still there? Is it possible to get the sample file? And if it's still reproducible do you observe it in all of your prototypes?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/stevahnes/figma-plugins/issues/13#issuecomment-796586592, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUDJMDGPGCCAF5VKVFGZVLTDCCHTANCNFSM4XA2ZS6Q.

stevahnes commented 3 years ago

Yes, and I’ve actually encountered some other issues happening as well:

Components are flipping vertically Transparency is not maintained Rare, but sometimes the layout massively changes.

This occurs when something is a component and we clone while deleting hidden layers and locking the objects

Can you reach out to me privately so I can invite you to our project for review?

On Mar 11, 2021, at 2:10 AM, Stevanus Satria @.***> wrote:

Ah! Thanks for following up - I lost track of things. Let me work on getting you a copy so you can see exactly what they are.

On Feb 14, 2021, at 11:52 PM, Stevanus Satria @. @.> wrote:

Hi @aarondewald https://github.com/aarondewald https://github.com/aarondewald https://github.com/aarondewald, I believe the issue is still recurring to you? If yes I really need to be able to replicate it in order to find the root cause. Otherwise, I can't fix it as it works fine in our mockups, both work ones and my personal ones.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub #13 (comment) https://github.com/stevahnes/figma-plugins/issues/13#issuecomment-778993184, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUDJMEW4KO4D4WOMT2ZIP3S7DADJANCNFSM4XA2ZS6Q https://github.com/notifications/unsubscribe-auth/ABUDJMEW4KO4D4WOMT2ZIP3S7DADJANCNFSM4XA2ZS6Q.

Hello @aarondewald https://github.com/aarondewald, have not heard from you in a while! I believe the issue is still there? Is it possible to get the sample file? And if it's still reproducible do you observe it in all of your prototypes?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/stevahnes/figma-plugins/issues/13#issuecomment-796586592, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUDJMDGPGCCAF5VKVFGZVLTDCCHTANCNFSM4XA2ZS6Q.

Hi @aarondewald, oh dear that's bad. How can I reach out to you personally? Really wanna get this fixed!

stevahnes commented 3 years ago

@aarondewald transparency should be fixed in v2.2.11; I missed out copying the values of the parent frames. The others are a bit trickier to debug and this weekend I am quite packed, so didn't have time to trace everything. I suspect it's related to the plugin not handling auto-layout properly. I'll continue working on it :)

stevahnes commented 3 years ago

@aarondewald the flipping elements bug is fixed v2.2.12; I rewrote the detachInstance logic, so instead of whitelisting items to deep clone I blacklist items to not deep clone. The last one is really tricky. I'll keep working on it!

stevahnes commented 3 years ago

Hi @aarondewald, been busy with work and looking for a new rental unit, so apologies for the delay with the last bug fix. I will try to get some time this coming weekend.

stevahnes commented 3 years ago

@aarondewald hello! Apologies for the 3 weeks delay. Finally got the chance to look into it. I found that the massive layout changes is actually due to the autolayout frames width not being copied properly. The quickest fix, for you, is to select all the "Answer Body" frames and drag it back to the right width, and the layout will be fixed. However, on my end I will definitely be looking into why the width and height aren't copied properly.