search

stevan / p5-App-Critique

An incremental refactoring tool for Perl powered by Perl::Critic
3 stars 4 forks source link

Simplified the file filter predication code generation. #26

Closed stuartskelton closed 8 years ago

stuartskelton commented 8 years ago

Ok, I may be a little guilty of golfing a little here, but this removes the brain ache of trying to keep track of what has been set or not.

The only reason I could get away with this is because all the checks were ANDs.

stevan commented 8 years ago

Looks mostly good to me, I am adding a few small comments in the code for discussion.

stevan commented 8 years ago

Okay, comments added, one question and one request.

stuartskelton commented 8 years ago

I have corrected the filters.

and:

I have also added back the table, however with a little change in the ordering, so the stages descend in their filters binary value, I think it makes it a little more readable, but I am happy to change it back if you disagree.

stuartskelton commented 8 years ago

Thinking about it too, I should probably switch Cols 1 and 2. too as that would fit with the logic.

stevan commented 8 years ago

Yeah, switching cols 1 and 2 would be good, I agree, after that, this patch is good, thanks!

stuartskelton commented 8 years ago

I have amended the last commit.